Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Prevent calling onClose() when shiftKey, ctrlKey or metaKey is pressed #1870

Merged
merged 6 commits into from Apr 26, 2023
Merged

Fix: Prevent calling onClose() when shiftKey, ctrlKey or metaKey is pressed #1870

merged 6 commits into from Apr 26, 2023

Conversation

bojanrajh
Copy link
Contributor

This PR checks for presence of shiftKey, ctrlKey or metaKey when clicking the result so users can open multiple search results without re-opening the search modal.

@netlify
Copy link

netlify bot commented Apr 26, 2023 •
edited

‼️ Deploy request for docsearch rejected.

Name Link
🔨 Latest commit 9455390

francoischalifour
francoischalifour reviewed Apr 26, 2023
View reviewed changes
Copy link
Member

@francoischalifour francoischalifour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks–that's a nice UX improvement!

packages/docsearch-react/src/DocSearchModal.tsx Outdated Show resolved Hide resolved
shortcuts
shortcuts approved these changes Apr 26, 2023
View reviewed changes
Copy link
Member

@shortcuts shortcuts left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lovely! thanks :)

francoischalifour
francoischalifour approved these changes Apr 26, 2023
View reviewed changes
Copy link
Member

@francoischalifour francoischalifour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@shortcuts shortcuts merged commit b9a3899 into algolia:main Apr 26, 2023
6 checks passed
@shortcuts
Copy link
Member

releasing here #1871

@bojanrajh
Copy link
Contributor Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@francoischalifour francoischalifour francoischalifour approved these changes

@shortcuts shortcuts shortcuts approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bojanrajh @shortcuts @francoischalifour