Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc(site): Fixed typos #277

Merged
merged 1 commit into from Mar 11, 2018
Merged

doc(site): Fixed typos #277

merged 1 commit into from Mar 11, 2018

Conversation

pborreli
Copy link
Contributor

@pborreli pborreli commented Mar 7, 2018

Summary

Fixed few typos

Result

Less typos

Care

Maybe the typo fix of isTextOrSubcatoryNonEmpty can provoke a regression somewhere/somehow ?

Copy link
Contributor

@Haroenv Haroenv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Just need to check if that template isn’t accidentally public api

@s-pace
Copy link

s-pace commented Mar 7, 2018

Wow, thats super fast.

new PR for you ;)

Thanks

Copy link

@s-pace s-pace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please @Haroenv double check the topic you have raised.

LGTM

@s-pace s-pace merged commit d3f0aac into algolia:master Mar 11, 2018
s-pace pushed a commit that referenced this pull request Mar 11, 2018
s-pace pushed a commit that referenced this pull request Mar 11, 2018
@pborreli
Copy link
Contributor Author

@s-pace tell me if you need me to do something about that issue

s-pace pushed a commit that referenced this pull request Mar 12, 2018
s-pace pushed a commit that referenced this pull request Mar 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants