Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(hierarchical): deselect item #342

Merged
merged 2 commits into from
Jul 11, 2022
Merged

fix(hierarchical): deselect item #342

merged 2 commits into from
Jul 11, 2022

Conversation

aallam
Copy link
Member

@aallam aallam commented Jul 6, 2022

Q A
Bug fix? yes
New feature? no
BC breaks? no
Related Issue FX-1567
Need Doc update no

Describe your change

Calling onSelectionChanged on already selected item doesn't introduce any change to the hierarchical tree.
The expected behavior would be to deselect the item and update the hierarchical tree.

hierarchical

@aallam aallam marked this pull request as ready for review July 6, 2022 13:24
@aallam aallam requested a review from VladislavFitz July 6, 2022 13:24
Copy link
Contributor

@VladislavFitz VladislavFitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job 👍

@aallam aallam merged commit 83a89f1 into master Jul 11, 2022
@aallam aallam deleted the fix/hierarchical-deselect branch July 11, 2022 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants