Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(range): filter range bounds init #346

Merged
merged 4 commits into from
Jul 19, 2022
Merged

fix(range): filter range bounds init #346

merged 4 commits into from
Jul 19, 2022

Conversation

aallam
Copy link
Member

@aallam aallam commented Jul 18, 2022

Q A
Bug fix? yes
New feature? no
BC breaks? no
Related Issue FX-1587
Need Doc update no

Describe your change

Fix bounds/range initialization to match the following:

Bounds/Range connectSearcher Behavior
Yes Yes The bounds retrieved from the first search operation, the range will match the value set using the constructor
No Yes The bounds retrieved from the first search operation, the range will match the bounds
Yes No The bounds/range from the constructor are used
No No Undefined behavior

VladislavFitz
VladislavFitz reviewed Jul 19, 2022
View reviewed changes
...tsearch/src/commonMain/kotlin/com/algolia/instantsearch/filter/range/FilterRangeConnector.kt
@@ -26,6 +26,15 @@ public data class FilterRangeConnector<T>(
) : AbstractConnection() where T : Number, T : Comparable<T> {

/**
* ```
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great explanation, I have to add the same one in the iOS version.

VladislavFitz
VladislavFitz approved these changes Jul 19, 2022
View reviewed changes
Copy link
Contributor

@VladislavFitz VladislavFitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good 👍

@aallam aallam merged commit 22cfed2 into master Jul 19, 2022
@aallam aallam deleted the fix/filter-range branch July 19, 2022 12:40
@amitlodha
Copy link

Hi, @aallam can you create a release version for same. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VladislavFitz VladislavFitz VladislavFitz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@aallam @amitlodha @VladislavFitz