fix(DynamicFacetList): ignoring of disjunctive facets when updating orderedFacets #385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aallam
approved these changes
Mar 7, 2023
...golia/instantsearch/filter/facet/dynamic/internal/DynamicFacetListConnectionSearcherIndex.kt
Outdated
Show resolved
Hide resolved
…filter/facet/dynamic/internal/DynamicFacetListConnectionSearcherIndex.kt Co-authored-by: Mouaad Aallam <mouaad.aallam@algolia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your change
Duplicate of the same issue in the InstantSearch iOS.
The disjunctive faceting doesn't work correctly with
DynamicFacetListproperly configured for disjunctive faceting.This happens due to ignoring the
disjunctiveFacetsproperty of theResponseSearchwhich contains the proper facet values when disjunctive faceting applied.What problem is this fixing?
The disjunctive faceting with
DynamicFacetListworks correctly.