fix(dynamic facets): update selections of facet order change #393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aallam
approved these changes
Jun 2, 2023
VladislavFitz
force-pushed
the
fix/update-dynamicfacets-on-facet-order
branch
from
580397e
to
dc3632f
Compare
VladislavFitz
added a commit
that referenced
this pull request
Jun 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your change
The clone of #289 for InstantSearch iOS.
This PR adds recalculation of the selections in the
DynamicFacetListViewModelon update of facets values. This is useful when the selected facets are predefined in theFilterState, but no selections update happens until the user's selection.What problem is this fixing?
The selection state of the
DynamicFacetListInteractoris correct even if the filters are preselected in theFilterState.