Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(search): add a flag to disable auto search trigger #397

Merged
merged 1 commit into from
Jun 16, 2023
Merged

fix(search): add a flag to disable auto search trigger #397

merged 1 commit into from
Jun 16, 2023

Conversation

aallam
Copy link
Member

@aallam aallam commented Jun 15, 2023

Q A
Bug fix? yes
New feature? no
BC breaks? no
Related Issue n/a
Need Doc update yes/no

Describe your change

Adds a flag searchOnQueryUpdate to disable auto search trigger on query update.

@aallam aallam force-pushed the fix/pagination-searchbox branch 3 times, most recently from 46fdace to 6ae30cd Compare June 15, 2023 14:42
VladislavFitz
VladislavFitz approved these changes Jun 16, 2023
View reviewed changes
Copy link
Contributor

@VladislavFitz VladislavFitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done 👍

@aallam aallam added this pull request to the merge queue Jun 16, 2023
Merged via the queue into master with commit 845bf06 Jun 16, 2023
2 checks passed
@aallam aallam deleted the fix/pagination-searchbox branch June 16, 2023 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VladislavFitz VladislavFitz VladislavFitz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@aallam @VladislavFitz