Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(insights): add serializer parameters (#401) #402

Merged
merged 1 commit into from
Dec 6, 2023

Conversation

tbra91
Copy link
Contributor

@tbra91 tbra91 commented Aug 15, 2023

Fixes crash when obfuscating.

Q A
Bug fix? yes
New feature? no
BC breaks? no
Related Issue Fix #401
Need Doc update no

Describe your change

Adds serializer parameters to InsightsEventDOMapper serialization calls.

What problem is this fixing?

Fixes a crash when obfuscating with R8 due to Kotlinx Serialization.

@tbra91 tbra91 requested a review from aallam as a code owner August 15, 2023 01:22
@KubaPreg
Copy link

@aallam any eta on fixing it?

@tbra91
Copy link
Contributor Author

tbra91 commented Nov 9, 2023

@aallam bump

@aallam aallam added this pull request to the merge queue Dec 6, 2023
Merged via the queue into algolia:master with commit cb068ac Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash in InsightsEventDOMapper when obfuscating with R8 due to Kotlinx Serializer
5 participants