fix(access-control): change access level from public to internal for …

…classes that will not be interfaced for V1
algolia · Jun 27, 2017 · be04629 · be04629
1 parent ba446e4
commit be04629
Show file tree

Hide file tree

Showing 8 changed files with 11 additions and 92 deletions.
diff --git a/Example/Example/FullDemo/FacetController.swift b/Example/Example/FullDemo/FacetController.swift
@@ -15,7 +15,6 @@ class FacetController: UIViewController, RefinementTableViewDataSource {
     var instantSearch: InstantSearch!
     @IBOutlet weak var refinementList: RefinementTableWidget!
     @IBOutlet weak var statLabel: UILabel!
-    var statLabelController: StatsLabelController!
 
     var refinementController: RefinementController!
 
@@ -28,8 +27,6 @@ class FacetController: UIViewController, RefinementTableViewDataSource {
 
         instantSearch = InstantSearch.shared
         instantSearch.register(widget: refinementList)
-        statLabelController = StatsLabelController(label: statLabel)
-        instantSearch.register(widget: statLabelController)
     }
 
     func tableView(_ tableView: UITableView, cellForRowAt indexPath: IndexPath, containing facet: String, with count: Int, is refined: Bool) -> UITableViewCell {

diff --git a/Sources/Library/Concrete/View/StatsLabelWidget.swift b/Sources/Library/Concrete/View/StatsLabelWidget.swift
@@ -37,7 +37,7 @@ import UIKit
     }
 }
 
-@objc public class StatsLabelController: NSObject, StatsViewDelegate, AlgoliaWidget {
+@objc internal class StatsLabelController: NSObject, StatsViewDelegate, AlgoliaWidget {
 
     var label: UILabel
 

diff --git a/Sources/Library/Concrete/ViewModel/Helpers/RefinementListHelper.swift b/Sources/Library/Concrete/ViewModel/Helpers/RefinementListHelper.swift
@@ -42,11 +42,11 @@ import InstantSearchCore
 }
 
 extension RefinementMenuViewModel {
-    @objc public func getRefinementList(params: SearchParameters,
-                                        facetCounts: [String: Int],
-                                        andFacetName facetName: String,
-                                        transformRefinementList: TransformRefinementList,
-                                        areRefinedValuesFirst: Bool) -> [FacetValue] {
+    @objc internal func getRefinementList(params: SearchParameters,
+                                          facetCounts: [String: Int],
+                                          andFacetName facetName: String,
+                                          transformRefinementList: TransformRefinementList,
+                                          areRefinedValuesFirst: Bool) -> [FacetValue] {
 
         let allRefinements = params.buildFacetRefinements()
         let refinementsForFacetName = allRefinements[facetName]

diff --git a/Sources/Library/Helpers.swift b/Sources/Library/Helpers.swift
@@ -97,7 +97,7 @@ private func == <T> (lhs: WeakObject<T>, rhs: WeakObject<T>) -> Bool {
     return lhs.object === rhs.object
 }
 
-public struct WeakSet<T: AnyObject>: Sequence {
+internal struct WeakSet<T: AnyObject>: Sequence {
 
     private var _objects: Set<WeakObject<T>>
 

diff --git a/Sources/Library/InstantSearchMultiIndex.swift b/Sources/Library/InstantSearchMultiIndex.swift
diff --git a/Sources/TestHelpers/FatalError.swift b/Sources/TestHelpers/FatalError.swift
@@ -9,20 +9,20 @@
 import Foundation
 
 // overrides Swift global `fatalError`
-public func fatalError(_ message: @autoclosure () -> String = "", file: StaticString = #file, line: UInt = #line) -> Never {
+internal func fatalError(_ message: @autoclosure () -> String = "", file: StaticString = #file, line: UInt = #line) -> Never {
     FatalErrorUtil.fatalErrorClosure(message(), file, line)
     unreachable()
 }
 
 /// This is a `noreturn` function that pauses forever
-public func unreachable() -> Never {
+internal func unreachable() -> Never {
     repeat {
         RunLoop.current.run()
     } while (true)
 }
 
 /// Utility functions that can replace and restore the `fatalError` global function.
-public struct FatalErrorUtil {
+internal struct FatalErrorUtil {
 
     // Called by the custom implementation of `fatalError`.
     static var fatalErrorClosure: (String, StaticString, UInt) -> Never = defaultFatalErrorClosure

diff --git a/Tests/FatalError.swift b/Tests/FatalError.swift
@@ -7,7 +7,7 @@
 //
 
 import Foundation
-import InstantSearch
+@testable import InstantSearch
 import XCTest
 
 extension XCTestCase {

diff --git a/instantsearch.xcodeproj/project.pbxproj b/instantsearch.xcodeproj/project.pbxproj
@@ -57,7 +57,6 @@
 		E27C16451E9394250091D79E /* SearchBarWidget.swift in Sources */ = {isa = PBXBuildFile; fileRef = E27C16391E9394250091D79E /* SearchBarWidget.swift */; };
 		E27C16461E9394250091D79E /* StatsLabelWidget.swift in Sources */ = {isa = PBXBuildFile; fileRef = E27C163A1E9394250091D79E /* StatsLabelWidget.swift */; };
 		E27C16471E9394250091D79E /* InstantSearch.swift in Sources */ = {isa = PBXBuildFile; fileRef = E27C163B1E9394250091D79E /* InstantSearch.swift */; };
-		E27C16481E9394250091D79E /* InstantSearchMultiIndex.swift in Sources */ = {isa = PBXBuildFile; fileRef = E27C163C1E9394250091D79E /* InstantSearchMultiIndex.swift */; };
 		E27C16491E9394250091D79E /* ClearAllWidget.swift in Sources */ = {isa = PBXBuildFile; fileRef = E27C163D1E9394250091D79E /* ClearAllWidget.swift */; };
 		E27C164A1E9394250091D79E /* ActivityIndicatorView.swift in Sources */ = {isa = PBXBuildFile; fileRef = E27C163E1E9394250091D79E /* ActivityIndicatorView.swift */; };
 		E27C164B1E9394250091D79E /* RefinableDelegate.swift in Sources */ = {isa = PBXBuildFile; fileRef = E27C163F1E9394250091D79E /* RefinableDelegate.swift */; };
@@ -157,7 +156,6 @@
 		E27C16391E9394250091D79E /* SearchBarWidget.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = SearchBarWidget.swift; sourceTree = "<group>"; };
 		E27C163A1E9394250091D79E /* StatsLabelWidget.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = StatsLabelWidget.swift; sourceTree = "<group>"; };
 		E27C163B1E9394250091D79E /* InstantSearch.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = InstantSearch.swift; sourceTree = "<group>"; };
-		E27C163C1E9394250091D79E /* InstantSearchMultiIndex.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = InstantSearchMultiIndex.swift; sourceTree = "<group>"; };
 		E27C163D1E9394250091D79E /* ClearAllWidget.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = ClearAllWidget.swift; sourceTree = "<group>"; };
 		E27C163E1E9394250091D79E /* ActivityIndicatorView.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = ActivityIndicatorView.swift; sourceTree = "<group>"; };
 		E27C163F1E9394250091D79E /* RefinableDelegate.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = RefinableDelegate.swift; sourceTree = "<group>"; };
@@ -431,7 +429,6 @@
 				E2231E961EC9F5A7002FCF82 /* Constants.swift */,
 				28F828821C494B2C00330CF4 /* Info.plist */,
 				E27C163B1E9394250091D79E /* InstantSearch.swift */,
-				E27C163C1E9394250091D79E /* InstantSearchMultiIndex.swift */,
 				E27A7BF01E97931E005B2506 /* ViewModelFetcher.swift */,
 				E2A477001EC61B43007CA367 /* InstantSearch-Bridging-Header.h */,
 			);
@@ -764,7 +761,6 @@
 				E2738FC71E9CC3F8002C002D /* RefinementMenuViewModelDelegate.swift in Sources */,
 				E2738FCB1E9CDDA0002C002D /* NumericControlViewModelDelegate.swift in Sources */,
 				E233BC031EBB78B600F5F5E1 /* FacetControlViewModel.swift in Sources */,
-				E27C16481E9394250091D79E /* InstantSearchMultiIndex.swift in Sources */,
 				E27C16451E9394250091D79E /* SearchBarWidget.swift in Sources */,
 				E27A7BEA1E955612005B2506 /* ResettableDelegate.swift in Sources */,
 				E2738FD21E9D1AFF002C002D /* RefinementListHelper.swift in Sources */,