fix: SwiftUI infinite scrolling issue #228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VladislavFitz
changed the title
VladislavFitz
force-pushed
the
fix/swiftui-infinite-scrolling
branch
from
f045faa
to
e7bfd0b
Compare
aallam
approved these changes
Jul 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The existing implementation of
HitsObservableControllerusesgetCurrentHitsfunction ofHitsInteractorto build an observable list of hits. That's why the infinite scrolling didn't work correctly due optimization which keeps only 4 most recents pages of hits in memory.This PR adds
hitscomputed property inHitsInteractorwhich ensures the correct hits pages to hits list by presenting the hits of unloaded pages asnilvalues.Result
Inifinite scrolling works correctly with
HitsObservableController.