Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: deprecate Boundable <-> Search Result Provider connection #230

Merged
merged 4 commits into from
Jul 14, 2022
Merged

chore: deprecate Boundable <-> Search Result Provider connection #230

merged 4 commits into from
Jul 14, 2022

Conversation

VladislavFitz
Copy link
Contributor

Summary

  • Deprecate the unused BoundableSearchResultProvderConnection to remove the ambiguity with BoundableHitsSearcherConnection .
  • Make the Number Range Demo more interactive by adding the search bar and stats

@VladislavFitz VladislavFitz requested a review from aallam July 4, 2022 13:05
@VladislavFitz VladislavFitz changed the title chore: Deprecate Boundable <-> Search Result Provider connection chore: deprecate Boundable <-> Search Result Provider connection Jul 4, 2022
aallam
aallam approved these changes Jul 5, 2022
View reviewed changes
Copy link
Member

@aallam aallam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's maybe a good idea to also update the Android demo :D

@VladislavFitz VladislavFitz merged commit bbde414 into master Jul 14, 2022
@VladislavFitz VladislavFitz deleted the chore/deprecate-boundable-search-result-provider-connection branch August 4, 2022 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aallam aallam aallam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@VladislavFitz @aallam