fix: send empty events packages if all non statisfying condition #268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aallam
approved these changes
Jan 25, 2023
VladislavFitz
force-pushed
the
fix/insights-empty-packages
branch
from
6d0e726
to
a6a6298
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
EventsProcessorofInsightspackage filters out event in package by acceptance condition (event was captured not longer than 4 days ago).If all events in the package don't satisfy this condition, an empty payload will be sent.
This PR adds a check to avoid useless network calls in this case.
Result
No network call happens if no event satisfy the acceptance criteria