Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v5.1.0 #85

Merged
merged 5 commits into from
Sep 5, 2019
Merged

Release v5.1.0 #85

merged 5 commits into from
Sep 5, 2019

Conversation

VladislavFitz
Copy link
Contributor

@VladislavFitz VladislavFitz commented Sep 4, 2019

Features:

  • A possibility to set a template table/collectionView cell provider for a hit which should be present in the collection, but result page of which is not loaded yet.

Fixes:

  • Private accessors dataSource/delegate in HitsCollectionController set public.

return hitsSource?.numberOfHits() ?? 0

guard let hitsSource = hitsSource else {
fatalError("Missing hits source")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One way we can improve the wording on this is: instead of just stating what is the problem, we can propose to them the solution to give them context.

Example:

The HitSource datasource has not been set. You need to set it by setting the hitsCollectionViewDataSource.hitsSource property.

@VladislavFitz VladislavFitz merged commit 23144df into master Sep 5, 2019
@VladislavFitz VladislavFitz deleted the feat/cell-template-for-missing-hit branch January 20, 2020 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants