fix: remove useless types (#3958)

* fix: remove useless types * fix: remove useless cast/ignore
algolia · Oct 23, 2019 · ddebf53 · ddebf53
1 parent e94752d
commit ddebf53
Show file tree

Hide file tree

Showing 5 changed files with 12 additions and 28 deletions.
diff --git a/src/connectors/query-rules/connectQueryRules.ts b/src/connectors/query-rules/connectQueryRules.ts
@@ -219,8 +219,6 @@ const connectQueryRules: QueryRulesConnector = (render, unmount = noop) => {
 
           // We track every change in the helper to override its state and add
           // any `ruleContexts` needed based on the `trackedFilters`.
-          // @ts-ignore
-          // @TODO: we have to update the definition to make it work
           helper.on('change', onHelperChange);
         }
 

diff --git a/src/lib/RoutingManager.ts b/src/lib/RoutingManager.ts
@@ -111,8 +111,6 @@ class RoutingManager implements Widget {
       this.router.write(route);
     };
 
-    // @ts-ignore
-    // @TODO: we have to update the definition to make it work
     helper.on('change', this.renderURLFromState);
 
     // Compare initial state and first render state to see if the query has been

diff --git a/src/lib/utils/mergeSearchParameters.ts b/src/lib/utils/mergeSearchParameters.ts
@@ -35,30 +35,20 @@ const mergeDisjunctiveFacets: Merger = (left, right) =>
     left
   );
 
-type HierarchicalFacet = {
-  name: string;
-  attributes: string[];
-  separator: string;
-};
-
 const mergeHierarchicalFacets: Merger = (left, right) =>
   left.setQueryParameters({
-    // @TODO: remove this cast when typings in helper are merged
-    hierarchicalFacets: (right.hierarchicalFacets as HierarchicalFacet[]).reduce(
-      (facets, facet) => {
-        const index = findIndex(facets, _ => _.name === facet.name);
-
-        if (index === -1) {
-          return facets.concat(facet);
-        }
-
-        const nextFacets = facets.slice();
-        nextFacets.splice(index, 1, facet);
-
-        return nextFacets;
-      },
-      left.hierarchicalFacets as HierarchicalFacet[]
-    ),
+    hierarchicalFacets: right.hierarchicalFacets.reduce((facets, facet) => {
+      const index = findIndex(facets, _ => _.name === facet.name);
+
+      if (index === -1) {
+        return facets.concat(facet);
+      }
+
+      const nextFacets = facets.slice();
+      nextFacets.splice(index, 1, facet);
+
+      return nextFacets;
+    }, left.hierarchicalFacets),
   });
 
 // Merge facet refinements

diff --git a/src/types/instantsearch.ts b/src/types/instantsearch.ts
@@ -102,7 +102,6 @@ export type Client = AlgoliaSearchClient;
 
 export type InstantSearch = {
   helper: AlgoliaSearchHelper | null;
-  widgets: Widget[]; // @TODO: remove once the RoutingManger uses the index
   mainHelper: AlgoliaSearchHelper | null;
   mainIndex: Index;
   insightsClient: AlgoliaInsightsClient | null;

diff --git a/test/mock/createInstantSearch.ts b/test/mock/createInstantSearch.ts
@@ -13,7 +13,6 @@ export const createInstantSearch = (
   return {
     mainIndex,
     mainHelper,
-    widgets: [], // @TODO: remove once the RoutingManger uses the index
     helper: mainHelper, // @TODO: use the Helper from the index once the RoutingManger uses the index
     templatesConfig: {},
     insightsClient: null,