-
Notifications
You must be signed in to change notification settings - Fork 514
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(infiniteHits): support cache #4431
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 838e5e2:
|
eunjae-lee
changed the title
test: use mocked searchClient
feat(infiniteHits): support cache
Jun 10, 2020
eunjae-lee
force-pushed
the
feat/infinite-hits-cache-2
branch
from
June 10, 2020 13:18
848d7d7
to
8df91f0
Compare
eunjae-lee
force-pushed
the
feat/infinite-hits-cache-2
branch
from
June 10, 2020 13:43
8df91f0
to
838e5e2
Compare
ghost
requested review from
francoischalifour and
yannickcr
and removed request for
a team
June 10, 2020 13:47
yannickcr
approved these changes
Jun 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR is the same as #4413 which was merged by mistake then reverted.
This PR is based on #4408, so it should be merged to
master
first.