Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/menu select widget #2045

Closed
wants to merge 25 commits into from
Closed

Feat/menu select widget #2045

wants to merge 25 commits into from

Conversation

iam4x
Copy link
Contributor

@iam4x iam4x commented Mar 13, 2017

I'm opening this PR to keep track progress of the menuSelect widget.

  • displays current refined value
  • update results after new selected refined value
  • rename RefinementSelect to menuSelect (needs to get some input from the team about naming)
  • tests
  • documentation & examples

What project are you opening a pull request for?

  • instantsearch.js (use develop base)

Summary
#868

Result

@vvo
Copy link
Contributor

vvo commented Mar 16, 2017

Deploy preview ready!

Built with commit dd4d668

https://deploy-preview-2045--algolia-instantsearch.netlify.com

Copy link
Contributor

@Haroenv Haroenv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like a well done feature

@iam4x
Copy link
Contributor Author

iam4x commented Mar 22, 2017

I've rebased on develop to make it possible to merge 👍

@bobylito
Copy link
Contributor

This will be a community widget. Thanks for the contribution.

@bobylito bobylito closed this Jun 13, 2017
@HellPat
Copy link

HellPat commented Jul 19, 2017

Is it already available somehow?

@Haroenv
Copy link
Contributor

Haroenv commented Jul 19, 2017

@Haroenv Haroenv deleted the feat/menuSelect-widget branch July 19, 2017 12:18
@vvo
Copy link
Contributor

vvo commented Jul 20, 2017

Seems that some good gems are only available in the dev app, should we make them available via recipes or something?

@Haroenv
Copy link
Contributor

Haroenv commented Jul 20, 2017

We were thinking of getting the dev app visible for sure, a nice way would be to link to the source from the published dev novel @vvo

cc @iam4x

@bobylito
Copy link
Contributor

The menu select rendering is the example of the connectMenu: https://community.algolia.com/instantsearch.js/v2/connectors/connectMenu.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants