fix(queryRuleCustomData): add default template #3650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for instantsearchjs ready! Built with commit e4c9817 |
Haroenv
approved these changes
Apr 4, 2019
francoischalifour
added a commit
that referenced
this pull request
Apr 11, 2019
# [3.3.0](v3.2.1...v3.3.0) (2019-04-11) ### Bug Fixes * **connectQueryRules:** improve tracked refinement type ([#3648](#3648)) ([e16ad57](e16ad57)) * **currentRefinements:** don't rely on ([#3672](#3672)) ([cd64bcf](cd64bcf)) * **queryRuleCustomData:** add default template ([#3650](#3650)) ([83e9eaa](83e9eaa)) * **QueryRuleCustomData:** pass data as object to templates ([#3647](#3647)) ([b8f8b4e](b8f8b4e)) * **queryRules:** fix types and stories ([#3670](#3670)) ([ba6e2e6](ba6e2e6)) * **routing:** apply windowTitle on first load ([#3669](#3669)) ([d553502](d553502)), closes [#3667](#3667) * **routing:** support parsing URLs with up to 100 refinements ([#3671](#3671)) ([6ddcfb6](6ddcfb6)) * **RoutingManager:** avoid stale uiState ([#3630](#3630)) ([e1588aa](e1588aa)) * **types:** improve InstantSearch types ([#3651](#3651)) ([db9b91e](db9b91e)) * **ua:** Update the User-Agent to use the new format ([#3616](#3616)) ([ab84c57](ab84c57)) ### Features * **infiniteHits:** add previous button ([#3645](#3645)) ([2c9e38d](2c9e38d)) * **queryRules:** add connectQueryRules connector ([#3597](#3597)) ([924cd99](924cd99)), closes [#3599](#3599) [#3600](#3600) * **queryRules:** add context features to Query Rules ([#3617](#3617)) ([922879e](922879e)), closes [#3602](#3602) ### Reverts * feat(infiniteHits): add previous button ([214c0fc](214c0fc))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a default template to the
queryRuleCustomDatawidget. This default template is a JSON dump of the custom data returned by the connector. It can help users understand what data structure to interact with before creating a custom template.This is the behavior we went for in the Vue InstantSearch implementation and in the Angular InstantSearch implementation.
See story →