feat(infiniteHits): add previous button #3645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yannickcr
requested review from
eunjae-lee,
tkrugg,
julienpa,
francoischalifour,
Haroenv and
samouss
|
Deploy preview for instantsearchjs ready! Built with commit d49a42c |
|
It's pretty annoying that we chose to do the styling for each button individually, this way you need to update the style to see a correct styling here |
francoischalifour
requested changes
Apr 4, 2019
src/components/InfiniteHits/__tests__/__snapshots__/InfiniteHits-test.js.snap
Outdated
Show resolved
Hide resolved
src/connectors/infinite-hits/__tests__/connectInfiniteHits-test.js
Outdated
Show resolved
Hide resolved
src/connectors/infinite-hits/__tests__/connectInfiniteHits-test.js
Outdated
Show resolved
Hide resolved
src/connectors/infinite-hits/__tests__/connectInfiniteHits-test.js
Outdated
Show resolved
Hide resolved
…t.js Co-Authored-By: yannickcr <yannick.croissant@gmail.com>
…t.js Co-Authored-By: yannickcr <yannick.croissant@gmail.com>
Co-Authored-By: yannickcr <yannick.croissant@gmail.com>
samouss
requested changes
Apr 8, 2019
samouss
requested changes
Apr 9, 2019
…revious is disabled
samouss
approved these changes
Apr 9, 2019
francoischalifour
requested changes
Apr 9, 2019
Co-Authored-By: yannickcr <yannick.croissant@gmail.com>
Co-Authored-By: yannickcr <yannick.croissant@gmail.com>
Co-Authored-By: yannickcr <yannick.croissant@gmail.com>
francoischalifour
approved these changes
Apr 10, 2019
yannickcr
added a commit
that referenced
this pull request
Apr 11, 2019
This reverts commit 2c9e38d.
francoischalifour
added a commit
that referenced
this pull request
Apr 11, 2019
# [3.3.0](v3.2.1...v3.3.0) (2019-04-11) ### Bug Fixes * **connectQueryRules:** improve tracked refinement type ([#3648](#3648)) ([e16ad57](e16ad57)) * **currentRefinements:** don't rely on ([#3672](#3672)) ([cd64bcf](cd64bcf)) * **queryRuleCustomData:** add default template ([#3650](#3650)) ([83e9eaa](83e9eaa)) * **QueryRuleCustomData:** pass data as object to templates ([#3647](#3647)) ([b8f8b4e](b8f8b4e)) * **queryRules:** fix types and stories ([#3670](#3670)) ([ba6e2e6](ba6e2e6)) * **routing:** apply windowTitle on first load ([#3669](#3669)) ([d553502](d553502)), closes [#3667](#3667) * **routing:** support parsing URLs with up to 100 refinements ([#3671](#3671)) ([6ddcfb6](6ddcfb6)) * **RoutingManager:** avoid stale uiState ([#3630](#3630)) ([e1588aa](e1588aa)) * **types:** improve InstantSearch types ([#3651](#3651)) ([db9b91e](db9b91e)) * **ua:** Update the User-Agent to use the new format ([#3616](#3616)) ([ab84c57](ab84c57)) ### Features * **infiniteHits:** add previous button ([#3645](#3645)) ([2c9e38d](2c9e38d)) * **queryRules:** add connectQueryRules connector ([#3597](#3597)) ([924cd99](924cd99)), closes [#3599](#3599) [#3600](#3600) * **queryRules:** add context features to Query Rules ([#3617](#3617)) ([922879e](922879e)), closes [#3602](#3602) ### Reverts * feat(infiniteHits): add previous button ([214c0fc](214c0fc))
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The InfiniteHits widget is used to display a list of results with a “Show more” button. The user can click on this button to display more results without leaving its current page context.
Each time the user click on the “Show more” button the user will navigate to a new page (provided that the routing option is enabled in InstantSearch).
However, in the case the user navigates directly to a particular page (direct link, previous button, page refresh) then the widget only displays the last result page.
This change add a previous button to the Infinite Hits widget to give the possibility to the user to load the previous result pages.
For implementation details see the full RFC.
Before being mergeable, this change requires an update in https://github.com/algolia/instantsearch-specs to add the new CSS classes:
Result
A "with previous button enabled" story has been added for the Instant Hits widget.
https://deploy-preview-3645--instantsearchjs.netlify.com/stories/iframe.html?id=infinitehits--with-previous-button-enabled&page=3
fixes #2835