refactor(lodash): remove isFinite usage #3709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for instantsearchjs ready! Built with commit d0e0f2c |
|
Number.isFinite isn't supported in IE11, where should we add a note for this? https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Number/isFinite#Browser_compatibility Otherwise this is fine, because lodash "polyfills" Number.isFinite: https://github.com/lodash/lodash/blob/4.17.11/lodash.js#L11628 |
|
Since I read that Lodash's We can use the top-level |
samouss
reviewed
Apr 19, 2019
Haroenv
approved these changes
Apr 23, 2019
yannickcr
approved these changes
Apr 23, 2019
francoischalifour
force-pushed
the
refactor/lodash-removal-isFinite
branch
from
13c8b48
to
d0e0f2c
Compare
samouss
reviewed
Apr 23, 2019
| @@ -0,0 +1,5 @@ | |||
| function isFiniteNumber(value: any): value is number { | |||
There was a problem hiding this comment.
We can add a comment to the polyfill version, since we don't provide a test.
francoischalifour
added a commit
that referenced
this pull request
Apr 26, 2019
francoischalifour
added a commit
that referenced
this pull request
Apr 26, 2019
* refactor(lodash): remove defaultsDeep usage (#3700) * refactor(lodash): remove noop usage (#3701) * refactor(lodash): remove first and last usage (#3704) * refactor(lodash): remove some usage (#3705) * refactor(lodash): remove isArray usage (#3708) * refactor(lodash): remove mapKeys usage (#3710) * refactor(lodash): remove forEach usage (#3702) * refactor(lodash): remove has usage (#3703) * refactor(lodash): remove isFinite usage (#3709) * refactor(lodash): add documentation for isFiniteNumber (#3722) * refactor(lodash): remove get usage (#3728) * refactor(lodash): remove isPlainObject usage (#3724) * refactor(lodash): remove reduce usage (#3725) * refactor(lodash): remove uniq usage (#3727) * refactor(lodash): remove range and times usage (#3721) * refactor(lodash): remove isEqual usage (#3723) * refactor(lodash): remove mapValues usage (#3729) * refactor(lodash): remove escape usage (#3730) * refactor(lodash): remove keys usage (#3731) * refactor(lodash): remove union usage (#3732) * refactor(lodash): remove curry usage (#3733) * refactor(lodash): remove find usage (#3706) * refactor(lodash): remove mergeWith usage (#3734) * chore(deps): remove lodash and @types/lodash
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes
lodash/isFiniteusage.