WIP: add missing modifierClick avoid preventDefault to links

TODO: tests (possibly something global that cmd-clicks on every link and shows the DOM didn't change?)
algolia · Jan 12, 2024 · 0eed703 · 0eed703
1 parent 305ed20
commit 0eed703
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 0 deletions.
diff --git a/packages/instantsearch.js/src/components/Breadcrumb/Breadcrumb.tsx b/packages/instantsearch.js/src/components/Breadcrumb/Breadcrumb.tsx
@@ -3,6 +3,7 @@
 import { cx } from '@algolia/ui-components-shared';
 import { h } from 'preact';
 
+import { isSpecialClick } from '../../lib/utils';
 import Template from '../Template/Template';
 
 import type { BreadcrumbConnectorParamsItem } from '../../connectors/breadcrumb/connectBreadcrumb';
@@ -86,6 +87,9 @@ const Breadcrumb = ({
                 className={cssClasses.link}
                 href={createURL(item.value)}
                 onClick={(event) => {
+                  if (isSpecialClick(event)) {
+                    return;
+                  }
                   event.preventDefault();
                   refine(item.value);
                 }}

diff --git a/packages/react-instantsearch/src/ui/Menu.tsx b/packages/react-instantsearch/src/ui/Menu.tsx
@@ -1,6 +1,7 @@
 import React from 'react';
 
 import { cx } from './lib/cx';
+import { isModifierClick } from './lib/isModifierClick';
 import { ShowMoreButton } from './ShowMoreButton';
 
 import type { ShowMoreButtonTranslations } from './ShowMoreButton';
@@ -102,6 +103,9 @@ export function Menu({
               className={cx('ais-Menu-link', classNames.link)}
               href={createURL(item.value)}
               onClick={(event) => {
+                if (isModifierClick(event)) {
+                  return;
+                }
                 event.preventDefault();
                 onRefine(item);
               }}