Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(error handling): add an error event #1585

Closed
olance opened this issue Nov 21, 2016 · 2 comments
Closed

feat(error handling): add an error event #1585

olance opened this issue Nov 21, 2016 · 2 comments
Labels
Design: API Scope: Core

Comments

@olance
Copy link
Contributor

olance commented Nov 21, 2016

Do you want to request a feature or report a bug?
It would be good to have an error event triggered by instantsearch.js when an API/network error occurs.

What is the current behavior?
Right now there's no (official) way to react to any error form Algolia's side

What is the expected behavior?
Having the capability to register a handler, something like search.on('error', (err) => { ... })
@olance olance changed the title feat(error handling): had an error event feat(error handling): add an error event Nov 21, 2016
@olance olance mentioned this issue Nov 21, 2016
Closed
@bobylito
Copy link
Contributor

Would it be ok if we just forward the error even from the helper?

@olance
Copy link
Contributor Author

olance commented Nov 21, 2016

I'm not sure we'd need more actually!

bobylito pushed a commit that referenced this issue Dec 28, 2017
feat(core): add an error event to monitor error from Algolia
19ce562 
Fix #1585
@bobylito bobylito mentioned this issue Dec 28, 2017
Merged
bobylito added a commit that referenced this issue Dec 29, 2017
@bobylito
feat(core): add an error event to monitor error from Algolia (#2642)
71c2d68 
Fix #1585
marielaures pushed a commit that referenced this issue Dec 29, 2017
@bobylito @marielaures
feat(core): add an error event to monitor error from Algolia (#2642)
5bac7a3 
Fix #1585
marielaures pushed a commit that referenced this issue Dec 29, 2017
@bobylito @marielaures
feat(core): add an error event to monitor error from Algolia (#2642)
aafa270 
Fix #1585
bobylito pushed a commit that referenced this issue Jan 2, 2018
v2.4.0
62410ea 
<a name=2.4.0></a>

* **pagination:** disable buttons if not results ([#2643](#2643)) ([9017b72](9017b72)), closes [#2014](#2014)
* **theme:** fix height of pagination ([#2641](#2641)) ([b3185e5](b3185e5))

* **core:** add a reload method on the InstantSearch component ([#2637](#2637)) ([e73ff13](e73ff13))
* **core:** add an error event to monitor error from Algolia ([#2642](#2642)) ([71c2d68](71c2d68)), closes [#1585](#1585)
* **core:** rename `reload` to `refresh` ([#2645](#2645)) ([9b8ac65](9b8ac65))
* **wrapWithHits:** enable async init ([#2635](#2635)) ([08a8747](08a8747))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Design: API Scope: Core
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@vvo @olance @bobylito