fix(react-instantsearch): properly add noRefinementRoot class on <RefinementList>
#6091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…RefinementList>`
sarahdayan
requested review from
a team,
dhayab and
Haroenv
and removed request for
a team
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit cc5f5b2:
|
dhayab
approved these changes
Mar 18, 2024
Haroenv
approved these changes
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When the
<RefinementList>is searchable and a user searches for a facet value that doesn't exist, the root should have the class.ais-RefinementList--noRefinement. This was however not the case because we were relying oncanRefinewhich remainstrueas long as the last search contains search results.Now we're relying on the items returned from SFFV.
In the future, we may want to reconsider what
canRefinemeans in the context ofconnectRefinementList, as the source of refinements comes from two places (main search and SFFV), but this would be breaking right now so we can keep it for later.