fix(react): ensure hitComponent
does not remount on rerenders
#6191
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6189
Summary
We should generally avoid defining components inline during render, when wrapping provided components it causes remounts on every render which can be a problem if they are using hooks like
useState
,useEffect
anduseRef
.Result
In this case we wrap it with
useMemo
as we can't just pass it to the UI component as is.Added tests to make sure they only mount once.