Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(meteorjs): lite build must point to the browser lite #1097

Merged
merged 1 commit into from
Jun 16, 2016

Conversation

vvo
Copy link
Contributor

@vvo vvo commented Jun 16, 2016

No description provided.

fixes #1024

Actually I had previously fixed #1024 by pointing to the lite build
(side effect).

But since https://github.com/algolia/algoliasearch-client-
js/issues/283 I had to make the client nodejs lite build point to the
nodejs normal build.

Then it would have tried to use the nodejs build in meteorjs on the
frontend.

Please meteorjs, fix this :)
@algobot
Copy link
Contributor

algobot commented Jun 16, 2016

By analyzing the blame information on this pull request, we identified @bobylito, @pixelastic and @jerskouille to be potential reviewers

@vvo vvo merged commit 265ace3 into develop Jun 16, 2016
@vvo vvo deleted the fix/meteorjs-lite-build branch June 16, 2016 15:43
@vvo vvo removed the in progress label Jun 16, 2016
vvo pushed a commit that referenced this pull request Jun 20, 2016
<a name="1.6.1"></a>
## [1.6.1](v1.6.0...v1.6.1) (2016-06-20)

### Bug Fixes

* **meteorjs:** lite build must point to the browser lite (#1097) ([265ace3](265ace3))
* **toggle:** read numerical facet results stats for toggle count (#1098) ([1feb539](1feb539)), closes [#1096](#1096)
* **website:** footer wording ([8355460](8355460))
francoischalifour added a commit that referenced this pull request Jan 24, 2019
This is a remaining comment from #1097 that should have been removed some time ago.
francoischalifour added a commit that referenced this pull request Jan 24, 2019
)

This is a remaining comment from #1097 that should have been removed some time ago.

It was about an `algoliasearch` import that is not present anymore.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants