docs(examples): add url sync #1542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vvo
reviewed
Nov 14, 2016
| constructor() { | ||
| super(); | ||
| const history = window.history; | ||
| this.state = {history, state: {...qs.parse(window.location.search.slice(1))}}; |
There was a problem hiding this comment.
Why do you need to store window.history in the state? For convenience?
There was a problem hiding this comment.
could totally be replaced with window.history each time yeah (like location)
There was a problem hiding this comment.
Ok let's do that otherwise we start wondering "Why is history here?"
vvo
reviewed
Nov 14, 2016
|
|
||
| render() { | ||
| return <App {...this.props} | ||
| state={this.state.state} |
There was a problem hiding this comment.
Maybe we could name it this.state.searchState?
mthuret
force-pushed
the
docs/url-sync-for-examples
branch
from
2c6b867
to
a4206f5
Compare
bobylito
approved these changes
Nov 14, 2016
|
LGTM, ultimately empty refinements entries could just be removed from the state I guess? |
|
Yes I was thinking the same. a new refactor to do ? :] |
Yep in another step :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
uses browser history and a 700 ms threshold.
the url sync on our examples does not cover:
I can add them if you think it worth it.