-
Notifications
You must be signed in to change notification settings - Fork 496
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
example/react-router-v4: Update push reference #2035
Conversation
not sure if exists a way for check |
@@ -91,7 +92,7 @@ class App extends Component { | |||
} | |||
|
|||
App.propTypes = { | |||
push: React.PropTypes.func.isRequired, | |||
history: React.PropTypes.object.isRequired, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
http://stackoverflow.com/a/26924696/3185307
{
history: React.PropTypes.shape({{
push: React.PropTypes.func.isRequired,
}),
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you're my hero
one opening bracket too much
@@ -95,7 +95,7 @@ App.propTypes = { | |||
history: PropTypes.shape({ | |||
push: PropTypes.func.isRequired, | |||
}), | |||
location: PropTypes.object.isRequired | |||
location: PropTypes.object.isRequired, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wut
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry my fault
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM after the comma dangle fix :D
What project are you opening a pull request for?
Summary
Related with #2023 (comment)