fix(types): fix wrong typing in getWidgetState #3693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eunjae-lee
requested review from
samouss and
francoischalifour
and removed request for
samouss
francoischalifour
approved these changes
Apr 15, 2019
|
Deploy preview for instantsearchjs ready! Built with commit 6095c81 |
tkrugg
added a commit
that referenced
this pull request
Apr 17, 2019
# [3.4.0](v3.3.0...v3.4.0) (2019-04-17) ### Bug Fixes * **storybook:** fix Hierarchical menu separator in Breadcrumb story ([#3695](#3695)) ([b3bf8ac](b3bf8ac)) * **tools:** use commonjs in bump-package-version.js ([#3699](#3699)) ([6a6dbe1](6a6dbe1)) * **types:** fix wrong typing in getWidgetState ([#3693](#3693)) ([b3c2154](b3c2154)) * **types:** remove unused Without type ([#3694](#3694)) ([656d000](656d000)) ### Features * **infiniteHits:** add previous button ([#3675](#3675)) ([2e6137b](2e6137b)) * **Insights:** Insights inside Instantsearch ([#3598](#3598)) ([387f41f](387f41f))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This fixes the wrong typing of
getWidgetState.Result
state->searchParametersinwidgetStateOptions.(https://www.algolia.com/doc/guides/building-search-ui/widgets/create-your-own-widgets/js/?language=javascript#the-widget-lifecycle-and-api)