fix(connectSortBy): do not throw with wrong indexes #3824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
|
Deploy preview for instantsearchjs ready! Built with commit b45d0c2 |
Haroenv
reviewed
May 28, 2019
samouss
approved these changes
May 28, 2019
eunjae-lee
pushed a commit
that referenced
this pull request
Jul 1, 2019
## [3.5.4](v3.5.3...v3.5.4) (2019-07-01) ### Bug Fixes * **connectSortBy:** do not throw with wrong indexes ([#3824](#3824)) ([2a84ee2](2a84ee2)) * **deps:** update dependency instantsearch.js to v3.5.3 ([#3877](#3877)) ([463f3bb](463f3bb)) * **escape:** make sure that __escaped does not get removed ([#3830](#3830)) ([fbafd22](fbafd22)) * **getRefinements:** check for facet before accessing its data ([#3842](#3842)) ([aadc769](aadc769)) * **panel:** return value from dispose ([#3895](#3895)) ([bceb78f](bceb78f)) * **voiceSearch:** remove event listeners on stop ([#3845](#3845)) ([688e36a](688e36a))
Haroenv
pushed a commit
that referenced
this pull request
Sep 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
sortByconnector used to throw an error when the current index wasn't listed in theitemsof the widget.This broke some users' apps when using
routing. If users type a URL with a wrong index name for thesortBywidget, it will throw straight away and break the InstantSearch lifecycle.This PR removes the error thrown and rathers warns only in development. The initial index (from the helper) is used if that happens.
I slightly changed the implementation because we were relying on the InstantSearch instance index (
instantSearch.indexName) and now use the helper index (helper.getIndex()). This shouldn't break anything and is more consistent within the connector.The deleted tests in the widget are now covered in the connector.