test(eslint): enable no-unnecessary-type-assertion #4842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's a lot of assertions in our code base that were once necessary, but that's no longer the case. This rule requires typescript, so files that are ignored in typescript also need to be ignored for these rules
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 3c712f2:
|
Haroenv
commented
Aug 20, 2021
|
|
||
| return () => { | ||
| bodyRef!.current!.removeChild(props.bodyElement); | ||
| node.removeChild(props.bodyElement); |
There was a problem hiding this comment.
the eslint rule actually highlighted this, as before bodyRef!.current! was not detected by the hooks rule, but once bodyRef! was changed to bodyRef, it highlighted that the ref probably was the wrong one in the cleanup function
Haroenv
requested review from
a team,
eunjae-lee and
tkrugg
and removed request for
a team
tkrugg
approved these changes
Aug 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a lot of assertions in our code base that were once necessary, but that's no longer the case.
This rule requires typescript, so files that are ignored in typescript also need to be ignored for these rules