refactor(bindEvent): move listener inside components #5528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was needlessly abstracted with a HOC, not allowing us to use this same function inside onClick of an individual hit, which could help with deduplicating sendEvent + bindEvent I didn't remove the `withInsightsListener` HOC, as it could (in theory) be used externally.
Haroenv
requested review from
a team,
FabienMotte and
aymeric-giraudet
and removed request for
a team
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 4c1b558:
|
FabienMotte
reviewed
Mar 8, 2023
Haroenv
added a commit
that referenced
this pull request
Mar 8, 2023
* refactor(bindEvent): move listener inside components This was needlessly abstracted with a HOC, not allowing us to use this same function inside onClick of an individual hit, which could help with deduplicating sendEvent + bindEvent I didn't remove the `withInsightsListener` HOC, as it could (in theory) be used externally. * remove unused data
Haroenv
added a commit
that referenced
this pull request
Apr 18, 2023
* refactor(bindEvent): move listener inside components This was needlessly abstracted with a HOC, not allowing us to use this same function inside onClick of an individual hit, which could help with deduplicating sendEvent + bindEvent I didn't remove the `withInsightsListener` HOC, as it could (in theory) be used externally. * remove unused data
Haroenv
added a commit
that referenced
this pull request
Apr 24, 2023
* refactor(bindEvent): move listener inside components This was needlessly abstracted with a HOC, not allowing us to use this same function inside onClick of an individual hit, which could help with deduplicating sendEvent + bindEvent I didn't remove the `withInsightsListener` HOC, as it could (in theory) be used externally. * remove unused data
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This was needlessly abstracted with a HOC, not allowing us to use this same function inside onClick of an individual hit, which could help with deduplicating sendEvent + bindEvent
I didn't remove the
withInsightsListenerHOC, as it could (in theory) be used externally.Result