fix(insights): keep track of script loading in global #5551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is needed for example in StrictMode with React InstantSearch Hooks, where there are two InstantSearch instances, but the first one never gets started. Before this PR, the "should load script" was linked to "should add window.aa", but that doesn't necessarily correspond if `start` is never called on that instance.
Haroenv
requested review from
a team,
sarahdayan and
aymeric-giraudet
and removed request for
a team
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 7b8c0e4:
|
sarahdayan
reviewed
Mar 17, 2023
packages/instantsearch.js/src/middlewares/__tests__/createInsightsMiddleware.ts
Show resolved
Hide resolved
packages/instantsearch.js/src/middlewares/createInsightsMiddleware.ts
Outdated
Show resolved
Hide resolved
sarahdayan
reviewed
Mar 20, 2023
packages/react-instantsearch-hooks/src/__tests__/integration.test.tsx
Outdated
Show resolved
Hide resolved
packages/react-instantsearch-hooks/src/__tests__/integration.test.tsx
Outdated
Show resolved
Hide resolved
packages/react-instantsearch-hooks/src/__tests__/integration.test.tsx
Outdated
Show resolved
Hide resolved
packages/react-instantsearch-hooks/src/__tests__/integration.test.tsx
Outdated
Show resolved
Hide resolved
sarahdayan
approved these changes
Mar 20, 2023
Haroenv
added a commit
that referenced
this pull request
Apr 18, 2023
* fix(insights): keep track of script loading in global This is needed for example in StrictMode with React InstantSearch Hooks, where there are two InstantSearch instances, but the first one never gets started. Before this PR, the "should load script" was linked to "should add window.aa", but that doesn't necessarily correspond if `start` is never called on that instance. * tests * whoops! * whoops * updates
Haroenv
added a commit
that referenced
this pull request
Apr 24, 2023
* fix(insights): keep track of script loading in global This is needed for example in StrictMode with React InstantSearch Hooks, where there are two InstantSearch instances, but the first one never gets started. Before this PR, the "should load script" was linked to "should add window.aa", but that doesn't necessarily correspond if `start` is never called on that instance. * tests * whoops! * whoops * updates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is needed for example in StrictMode with React InstantSearch Hooks, where there are two InstantSearch instances, but the first one never gets started.
Before this PR, the "should load script" was linked to "should add window.aa", but that doesn't necessarily correspond if
startis never called on that instance.Result
insights client loads in strict mode