Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(vue-instantsearch): properly add noRefinement class on <ais-refinement-list> #6095

Merged
merged 2 commits into from Mar 19, 2024
Merged

fix(vue-instantsearch): properly add noRefinement class on <ais-refinement-list> #6095

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a2b5faa
fix(vue-instantsearch): properly add `noRefinement` class on `<ais-re…
sarahdayan Mar 19, 2024
df173a4
chore: add major note
sarahdayan Mar 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 2 additions & 0 deletions packages/instantsearch.js/src/connectors/refinement-list/connectRefinementList.ts
View file
Open in desktop
Expand Up @@ -126,6 +126,8 @@ export type RefinementListRenderState = {
isFromSearch: boolean;
/**
* `true` if a refinement can be applied.
* @MAJOR: reconsider how `canRefine` is computed so it both accounts for the
* items returned in the main search and in SFFV.
*/
canRefine: boolean;
/**
Expand Down
2 changes: 1 addition & 1 deletion packages/vue-instantsearch/src/components/RefinementList.vue
View file
Open in desktop
@@ -1,6 +1,6 @@
<template>
<div
:class="[suit(), !state.canRefine && suit('', 'noRefinement')]"
:class="[suit(), items.length === 0 && suit('', 'noRefinement')]"
v-if="state"
>
<slot
Expand Down