feat(next-app-router): listen to external URL changes #6107
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6077
Summary
The App Router does not have events like the Pages router had, so we didn't implement a way to listen to external URL changes yet.
Result
The way to go is to use
useEffect
for that, as stated on their docsI externalised everything into a hook to make the code easier to read and more focused, and to allow to do ISR / static generation more easily in the future (
useSearchParams
makes the page opt-out of such features)