Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(requests): don't fire a request when there are no widgets #6185

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

fix(requests): don't fire a request when there are no widgets #6185

wants to merge 3 commits into from

Commits on May 7, 2024

  1. fix(requests): don't fire a request when there are no widgets 

    Still to investigate further. I believe this won't have any negative repercussions, but at least some test cases will need to be written, as these don't seem to exist yet.

Comes out of an attempt to fix #6174 before realising that behaviour was happening

Likely optimisation possible once this is done is to remove extra checks in:
- https://github.com/algolia/instantsearch/blob/1405aebb52cd84b02a4f645ee5395763f4878b79/packages/instantsearch.js/src/widgets/index/index.ts#L477-L479
- https://github.com/algolia/instantsearch/blob/1b683c5ebbcae4a77a43ff2034da406c9eb0dbc4/packages/instantsearch.js/src/lib/InstantSearch.ts#L671-L681
    @Haroenv
    Haroenv committed May 7, 2024
    Configuration menu
    Copy the full SHA
    46b01b0 View commit details
    Browse the repository at this point in the history

  2. optim

    @Haroenv
    Haroenv committed May 7, 2024
    Configuration menu
    Copy the full SHA
    853c4e5 View commit details
    Browse the repository at this point in the history

  3. skip for now, this test should be higher level and check that helper … 

    …search is called
    @Haroenv
    Haroenv committed May 7, 2024
    Configuration menu
    Copy the full SHA
    2fe1910 View commit details
    Browse the repository at this point in the history