Do not use index prefix in settings files #15
Conversation
src/Console/BackupCommand.php
Outdated
| @@ -86,8 +86,14 @@ protected function saveSettings($indexName) | |||
|
|
|||
| protected function saveSynonyms($indexName) | |||
| { | |||
| <<<<<<< HEAD | |||
There was a problem hiding this comment.
This looks like an accidental committed line?
julienbourdeau
force-pushed
the
feat/index-prefix-in-files
branch
from
e7b3788
to
8b52bfc
Compare
|
Any update on whether this PR will be merged? |
|
Ping @julienbourdeau. |
|
@julienbourdeau Any change to merge this PR in? Would be very useful for current project for me already, separate from the proposed changes in #16 ... 😅 |
|
The main reason is that because it's a BC break, I wanted to get more in the PR. But I think it has been long enough, I'll release this afternoon 🎉 👍 |
|
@julienbourdeau Sorry to ping you again on this PR, but has something changed that prevents this PR from being merged? Anything I can help with? |
julienbourdeau
force-pushed
the
feat/index-prefix-in-files
branch
from
8b52bfc
to
5f4e039
Compare
|
@qrazi Thanks for pinging me. I merge the other one and reworked this one to work with it. I'll run a few tests and tag the new version tomorrow if everything goes well. |
julienbourdeau
force-pushed
the
feat/index-prefix-in-files
branch
from
9fa3d18
to
a6eba04
Compare
Fix #14
Please comment on the issue.