Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support new Scout version. #19

Merged
merged 2 commits into from
Feb 27, 2018
Merged

Support new Scout version. #19

merged 2 commits into from
Feb 27, 2018

Conversation

tomcoonen
Copy link
Contributor

No description provided.

@adiachenko adiachenko mentioned this pull request Feb 14, 2018
Closed
@julienbourdeau
Copy link
Contributor

Thanks for your contribution! 🎉
We need to keep compatibility with Scout 3 for now, like we did in the this PR for the macro extension: https://github.com/algolia/laravel-scout-algolia-macros/pull/14/files

@tomcoonen
Copy link
Contributor Author

@julienbourdeau Ofcourse, I upped the version to adhere to this. But since there are no breaking changes this is fine too :)

Do you want me to update this PR or will you fix it?

@julienbourdeau julienbourdeau merged commit afc5d32 into algolia:master Feb 27, 2018
@julienbourdeau
Copy link
Contributor

All good, Thanks for your first contrib! Feel free to open any new PR ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tomcoonen @julienbourdeau