Fixed an issue when parsing an empty string.

algolia · May 22, 2016 · 42cce74 · 42cce74
1 parent 0dfbab6
commit 42cce74
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 0 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,8 @@
 ## CHANGELOG
 
+### 0.0.3
+- Fixed an issue when parsing an empty string.
+
 ### 0.0.2
 - Added a way to parse content from a URL.
 

diff --git a/src/DOMParser.php b/src/DOMParser.php
@@ -177,6 +177,10 @@ public function parse($dom)
         $this->init();
         $dom = new \simple_html_dom((string) $dom);
 
+        if (null === $dom->root) {
+            return array();
+        }
+
         // We filter the exclusion first to be able to use a global selector.
         $this->filterExcluded($dom);
 

diff --git a/tests/DOMParserTest.php b/tests/DOMParserTest.php
@@ -206,4 +206,11 @@ public function testParseURLRaisesAnExceptionIfUnreachableURL()
         $parser = new DOMParser();
         $parser->parseURL('https://nothing.algolia.biz');
     }
+
+    public function testHandlesEmptyStringGracefully()
+    {
+        $parser = new DOMParser();
+        $records = $parser->parse('');
+        $this->assertEquals(array(), $records);
+    }
 }