fix: fixed crashing on circular React elements #619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
armandabric
approved these changes
Sep 28, 2021
Andarist
force-pushed
the
fix/circular-forward-ref
branch
from
4bca77a
to
76ecbe4
Compare
Andarist
force-pushed
the
fix/circular-forward-ref
branch
from
76ecbe4
to
2572941
Compare
|
@armandabric done, I've also refactored the added test as that has been unblocked when #617 got merged in |
|
@armandabric just a friendly 🏓 because you have been going through issues and PRs and didn't merge this one, so maybe you have missed it. |
armandabric
approved these changes
Sep 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.