feat: support more element types #617
Conversation
| commonjs({ | ||
| sourceMap: true, | ||
| namedExports: { | ||
| react: ['isValidElement'], | ||
| }, | ||
| }), |
There was a problem hiding this comment.
Can you explain why you have to change that in the context of this PR?
There was a problem hiding this comment.
commonjs plugin is only needed when you actually want to bundle a commonjs dependency - you don't really want that with react since you are leaving it as external (like you should), so this was actually a "dead"/redundant config
There was a problem hiding this comment.
Hm, could you be more specific? maybe I've explained this poorly - so let me rephrase: the removed code that was not actually used and it wasn't doing anything here. And how this config now is defined is correct - from my point of view this change is "sound" and correct. There is no regression here so this can be merged "as is". Please let me know if this addresses your concerns - if not I can try to explain it further and in more detail.
There was a problem hiding this comment.
Ho! Sorry I just wanted to said Let's change this! in the meaning of accepting your change with pleasure. Sorry for the wrong wording 🙊
|
@armandabric I will look into the Flow issue reported by CI soon-ish, should be a trivial fix |
Andarist
force-pushed
the
support-more-element-types
branch
from
b815293
to
6652007
Compare
|
@armandabric I've fixed the Flow issue 🎉 Also - I think that you have wanted to link another issue/PR since #617 is this one |
src/parser/parseReactElement.js
Outdated
| // this is "unknown" case and will most likely result in `[object Object]` | ||
| // it's fine though as we can't display anything meaningful anyway here |
There was a problem hiding this comment.
Let me know if you prefer returning "UnknownElementType" here or something.
There was a problem hiding this comment.
I like your idea to return UnknownElementType. It will help to debug issue.
|
For function MyComponent() {
return
}
const LazyComponent = React.lazy(async () => {
return MyComponent
});
const root = React.render(
<LazyComponent />
);
// for react-dev-tools
expect(jsxToString(root)).toBe(<Lazy />); // first
expect(jsxToString(root)).toBe(<MyComponent />); // then
// for `@storybook/addon-docs` i will except
expect(jsxToString(root)).toBe(<Lazy(MyComponent) />); // thenAny suggestions about element to Source code? |
|
Ah yes - I was wondering about this case but the problem here is that this |
No description provided.