fix(formatting): trailling space #205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes algolia#135 BREAKING CHANGE: Trailing are now preserved. In some rare case, `react-element-to-jsx-string` failed to respect the JSX specs for the trailing space. Event is the space were in the final output. There were silentrly ignored by JSX parser. This commit fix this bug by protecting the trailing space in the output. If we take the JSX: ```jsx <div> foo <strong>bar</strong> baz </div> ``` Before it was converted to (the trailing space are replace by `*` for the readability): ```html <div> foo* <strong> bar </strong> *baz </div> ``` Now there are preserved: ```html <div> foo{' '} <strong> bar </strong> {' '}baz </div> ```
armandabric
force-pushed
the
fix/trailing-space
branch
from
83be929
to
db6fd3b
Compare
armandabric
commented
Oct 8, 2017
| '<div>\n \n</div>' | ||
| `<div> | ||
| {' '} | ||
| </div>` |
There was a problem hiding this comment.
I do not like this output. But the previous one were also not pretty... so I guess we have to look at it in a dedicated PR.
There was a problem hiding this comment.
we can always provide an option to remove trailing whitespace no?, wait no, that's different. It should be kept I guess.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #135
BREAKING CHANGE: Trailling are now preserved. In some rare case,
react-element-to-jsx-stringfailed to respect the JSX specs for the trailing space. Event is the space were in the final output. There were silentrly ignored by JSX parser. This commit fix this bug by protecting the trailing space in the output.If we take the JSX:
Before it was converted to (the trailing space are replace by
*for the readability):Now there are preserved: