Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(build): replace babel-preset-es2015 by @babel/preset-env #351

Merged
merged 4 commits into from
Sep 18, 2019

Conversation

armandabric
Copy link
Collaborator

@armandabric armandabric commented Jan 27, 2019

This also unlock the upgrade to jest v24 and rollup v1

This PR will fix #299, fix #304, fix #313, fix #334, fix #341 and fix #350

We will get rid of these staging PR 💪

import sortObject from './sortObject';
import parseReactElement from './../parser/parseReactElement';
import formatTreeNode from './formatTreeNode';
import formatFunction from './formatFunction';
import spacer from './spacer';
import type { Options } from './../options';

// Rollup fail to correctly import `stringify-object` so we have to use a workaround
const stringify = (...args) => stringifyObject.default(...args);
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The import * as stringifyObject from 'stringify-object'; and this workaround allow us to avoid the rollup issue where @frytyler get stuck into in PR #313

@armandabric
Copy link
Collaborator Author

armandabric commented Sep 16, 2019

  • Compare the bundle before/after this PR to ensure everything is OK

@armandabric armandabric merged commit fe3375f into algolia:master Sep 18, 2019
@armandabric armandabric deleted the support/babel-preset-env branch September 18, 2019 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dependency deprecation warning: babel-preset-es2015 (npm)
1 participant