fix(metadata): stricter detection of user agent (#3184)

* fix(metadata): stricter detection of user agent 1. react native has window, but no navigator 2. in potentially other environments document might be undefined * add test
algolia · Oct 27, 2021 · 994c8ae · 994c8ae
1 parent aa2eb9b
commit 994c8ae
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 2 deletions.
diff --git a/packages/react-instantsearch-core/src/core/__tests__/metadata.ts b/packages/react-instantsearch-core/src/core/__tests__/metadata.ts
@@ -48,6 +48,17 @@ describe('isMetadataEnabled', () => {
     expect(isMetadataEnabled()).toBe(false);
   });
 
+  it("does not enable when there's no navigator (react native)", () => {
+    setUserAgent(algoliaUserAgent);
+
+    // @ts-expect-error
+    delete global.window;
+    // @ts-expect-error
+    global.window = {};
+
+    expect(isMetadataEnabled()).toBe(false);
+  });
+
   it('metadata enabled returns true', () => {
     setUserAgent(algoliaUserAgent);
 

diff --git a/packages/react-instantsearch-core/src/core/metadata.ts b/packages/react-instantsearch-core/src/core/metadata.ts
@@ -3,8 +3,11 @@ import type { Widget } from './createWidgetsManager';
 
 export function isMetadataEnabled() {
   return (
-    typeof window !== 'undefined' &&
-    window.navigator.userAgent.includes('Algolia Crawler')
+    typeof window === 'object' &&
+    typeof window.navigator === 'object' &&
+    typeof window.navigator.userAgent === 'string' &&
+    window.navigator.userAgent.includes('Algolia Crawler') &&
+    typeof window.document === 'object'
   );
 }