refactor(lodash): pick (#2432)

* refactor(lodash): pick replaced by destructuring * chore: remove isEmpty variable
algolia · May 13, 2019 · f170609 · f170609
1 parent c0e150b
commit f170609
Show file tree

Hide file tree

Showing 3 changed files with 60 additions and 37 deletions.
diff --git a/packages/react-instantsearch-dom/src/components/HierarchicalMenu.js b/packages/react-instantsearch-dom/src/components/HierarchicalMenu.js
@@ -1,4 +1,3 @@
-import { pick } from 'lodash';
 import React, { Component } from 'react';
 import PropTypes from 'prop-types';
 import { translatable } from 'react-instantsearch-core';
@@ -51,20 +50,26 @@ class HierarchicalMenu extends Component {
   };
 
   render() {
+    const {
+      translate,
+      items,
+      showMore,
+      limit,
+      showMoreLimit,
+      canRefine,
+      className,
+    } = this.props;
     return (
       <List
         renderItem={this.renderItem}
         cx={cx}
-        {...pick(this.props, [
-          'translate',
-          'items',
-          'showMore',
-          'limit',
-          'showMoreLimit',
-          'isEmpty',
-          'canRefine',
-          'className',
-        ])}
+        translate={translate}
+        items={items}
+        showMore={showMore}
+        limit={limit}
+        showMoreLimit={showMoreLimit}
+        canRefine={canRefine}
+        className={className}
       />
     );
   }

diff --git a/packages/react-instantsearch-dom/src/components/Menu.js b/packages/react-instantsearch-dom/src/components/Menu.js
@@ -1,4 +1,3 @@
-import { pick } from 'lodash';
 import React, { Component } from 'react';
 import PropTypes from 'prop-types';
 import { translatable } from 'react-instantsearch-core';
@@ -62,23 +61,33 @@ class Menu extends Component {
   };
 
   render() {
+    const {
+      translate,
+      items,
+      showMore,
+      limit,
+      showMoreLimit,
+      isFromSearch,
+      searchForItems,
+      searchable,
+      canRefine,
+      className,
+    } = this.props;
     return (
       <List
         renderItem={this.renderItem}
         selectItem={this.selectItem}
         cx={cx}
-        {...pick(this.props, [
-          'translate',
-          'items',
-          'showMore',
-          'limit',
-          'showMoreLimit',
-          'isFromSearch',
-          'searchForItems',
-          'searchable',
-          'canRefine',
-          'className',
-        ])}
+        translate={translate}
+        items={items}
+        showMore={showMore}
+        limit={limit}
+        showMoreLimit={showMoreLimit}
+        isFromSearch={isFromSearch}
+        searchForItems={searchForItems}
+        searchable={searchable}
+        canRefine={canRefine}
+        className={className}
       />
     );
   }

diff --git a/packages/react-instantsearch-dom/src/components/RefinementList.js b/packages/react-instantsearch-dom/src/components/RefinementList.js
@@ -1,4 +1,3 @@
-import { pick } from 'lodash';
 import React, { Component } from 'react';
 import PropTypes from 'prop-types';
 import { translatable } from 'react-instantsearch-core';
@@ -67,23 +66,33 @@ class RefinementList extends Component {
   };
 
   render() {
+    const {
+      translate,
+      items,
+      showMore,
+      limit,
+      showMoreLimit,
+      isFromSearch,
+      searchForItems,
+      searchable,
+      canRefine,
+      className,
+    } = this.props;
     return (
       <List
         renderItem={this.renderItem}
         selectItem={this.selectItem}
         cx={cx}
-        {...pick(this.props, [
-          'translate',
-          'items',
-          'showMore',
-          'limit',
-          'showMoreLimit',
-          'isFromSearch',
-          'searchForItems',
-          'searchable',
-          'canRefine',
-          'className',
-        ])}
+        translate={translate}
+        items={items}
+        showMore={showMore}
+        limit={limit}
+        showMoreLimit={showMoreLimit}
+        isFromSearch={isFromSearch}
+        searchForItems={searchForItems}
+        searchable={searchable}
+        canRefine={canRefine}
+        className={className}
         query={this.state.query}
       />
     );