This repository has been archived by the owner on Dec 30, 2022. It is now read-only.
feat(hooks): add useRange #3198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Haroenv
requested review from
a team,
dhayab and
tkrugg
and removed request for
a team
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 7afbed9:
|
|
✔️ Deploy Preview for react-instantsearch ready! 🔨 Explore the source changes: 7afbed9 🔍 Inspect the deploy log: https://app.netlify.com/sites/react-instantsearch/deploys/619d41b552e6c900072dab6a 😎 Browse the preview: https://deploy-preview-3198--react-instantsearch.netlify.app |
dhayab
reviewed
Nov 18, 2021
dhayab
reviewed
Nov 18, 2021
dhayab
approved these changes
Nov 22, 2021
Haroenv
force-pushed
the
feat/hooks-range
branch
from
963a75d
to
f8660a2
Compare
tkrugg
reviewed
Nov 23, 2021
tkrugg
approved these changes
Nov 23, 2021
| refine([from, to]); | ||
| }} | ||
| > | ||
| <input |
There was a problem hiding this comment.
We don't use the step property?
There was a problem hiding this comment.
can set it, I'm not really a fan on how precision gets turned into step in InstantSearch.js, seems like needless indirection
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
implement useRange
Result
example implemented RangeInput with approximately the same code as existing React InstantSearch, with the value/start transformations done in InstantSearch as well: https://github.com/algolia/instantsearch.js/blob/dcbbd8804b4b6471d24820b42826b57388974c27/src/widgets/range-input/range-input.tsx#L144-L154
FX-443