This repository has been archived by the owner on Dec 30, 2022. It is now read-only.
fix(hooks): allow importing via require #3257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 3cc4f58:
|
This comment has been minimized.
This comment has been minimized.
|
✔️ Deploy Preview for react-instantsearch ready! 🔨 Explore the source changes: 3cc4f58 🔍 Inspect the deploy log: https://app.netlify.com/sites/react-instantsearch/deploys/61dd7eb8b4122d0007f02009 😎 Browse the preview: https://deploy-preview-3257--react-instantsearch.netlify.app |
This comment has been minimized.
This comment has been minimized.
Haroenv
requested review from
a team,
dhayab,
FabienMotte and
francoischalifour
and removed request for
a team and
FabienMotte
dhayab
approved these changes
Jan 11, 2022
francoischalifour
approved these changes
Jan 11, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
opposite of making sure esm is fully esm, the cjs also needs to be fully cjs.
Result