This repository has been archived by the owner on Dec 30, 2022. It is now read-only.
feat(server): load data twice in the case of dynamic widget usage #3268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
see https://codesandbox.io/s/keen-moon-wdxou for the use case fixed by this PR
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 77ce0f1:
|
|
✔️ Deploy Preview for react-instantsearch ready! 🔨 Explore the source changes: 77ce0f1 🔍 Inspect the deploy log: https://app.netlify.com/sites/react-instantsearch/deploys/61ea881593d1d70008f10940 😎 Browse the preview: https://deploy-preview-3268--react-instantsearch.netlify.app |
Haroenv
commented
Jan 21, 2022
packages/react-instantsearch-dom/src/core/__tests__/createInstantSearchServer.js
Show resolved
Hide resolved
Haroenv
requested review from
a team,
dhayab and
francoischalifour
and removed request for
a team
francoischalifour
approved these changes
Jan 21, 2022
Haroenv
requested review from
sarahdayan and
francoischalifour
and removed request for
dhayab
sarahdayan
approved these changes
Jan 21, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Same as #3259, but for React InstantSearch core, not hooks.
We render twice in the case that dynamic widgets are discovered
Result