This repository has been archived by the owner on Dec 30, 2022. It is now read-only.
fix(hooks): apply initial search parameters in useConnector #3276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Haroenv
commented
Jan 24, 2022
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 29a428b:
|
Haroenv
commented
Jan 24, 2022
|
|
||
| // Initial render state from manual `getWidgetRenderState` | ||
| expect(result.current).toEqual({ | ||
| query: 'testio', |
There was a problem hiding this comment.
before the changes in useConnector, this is query: ''
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
鉁旓笍 Deploy Preview for react-instantsearch ready! 馃敤 Explore the source changes: 29a428b 馃攳 Inspect the deploy log: https://app.netlify.com/sites/react-instantsearch/deploys/61eebf5251d9160007adc543 馃槑 Browse the preview: https://deploy-preview-3276--react-instantsearch.netlify.app |
Haroenv
changed the title
Haroenv
requested review from
francoischalifour,
a team and
dhayab
and removed request for
a team
francoischalifour
approved these changes
Jan 24, 2022
packages/react-instantsearch-hooks/src/connectors/__tests__/useSearchBox.test.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: Fran莽ois Chalifour <francoischalifour@users.noreply.github.com>
dhayab
approved these changes
Jan 24, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
the state of "results" when not doing server side rendering isn't aware of the widgets yet. This is incorrect, and thus we need to call getWidgetSearchParameters before rendering.
This is still wrong when the state has been set by another widget, in the case of breadcrumb/hierarchical menu. I think that can be fixed by having both widgets apply the same state (maybe the already do it, I didn't test)
Result
slower initial mount, but actually correct 馃摝
cases to test: