This repository has been archived by the owner on Dec 30, 2022. It is now read-only.
chore(babel): migration to Babel 7 [PART-1] #1888
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samouss
force-pushed
the
chore/babel7-p1-migration
branch
from
0514843
to
4c1eae8
Compare
samouss
changed the title
|
Deploy preview for react-instantsearch ready! Built with commit cb7330f https://deploy-preview-1888--react-instantsearch.netlify.com |
samouss
force-pushed
the
chore/babel7-p1-migration
branch
from
b8fbfe9
to
1d1a983
Compare
Haroenv
reviewed
Jan 14, 2019
samouss
force-pushed
the
chore/babel7-p1-migration
branch
from
1d1a983
to
3f5cb84
Compare
samouss
force-pushed
the
chore/babel7-p1-migration
branch
from
3f5cb84
to
9ca3d52
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR moves packages, Storybook, docgen to Babel 7. Only the examples are still built with Babel 6 but they are outside of the workspaces. We can update them later. The major change is that we now use the project-wide configuration
babel.config.jsrather than scoped.babelrc. We only have one point of contact for the all projects. We can write overrides per files / folders to apply a specific set of plugins to the matches (like we do formapspackage).The downside of this approach is that since we called
babelfrom a nested level we have to provide a flag to tell Babel to find the proper configuration. Previously it was automatic, but not anymore. There is mode to callupwardto walks and find the correct configuration. Note that we are gonna hoist all the build step at the top of the package so this mode won't be used anymore at some point (at least for thepackages).Last downside of this change is the bundle size, since Babel 7 is closer to the spec it generates more helpers to actually check if the code is valid or not. There is a
loosemode to avoid this but we can get rid of this increase with@babel/runtime. It's implemented in the next PR.