-
Notifications
You must be signed in to change notification settings - Fork 387
fix(ua): change the User-Agent to use the new specs lib (version) #2209
Conversation
Deploy preview for react-instantsearch ready! Built with commit ba7650b https://deploy-preview-2209--react-instantsearch.netlify.com |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks correct to me, but would need to be checked if it doesn't break Looker dashboards by now following the specs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now that we change it would be nice to be able to differentiate which packages make the request: react-instantsearch-dom
, react-instantsearch-dom/server
, react-instantsearch-native
, react-instantsearch-core
.
yes! can we have react-instantsearch-server directly? |
You mean |
yes to simplify the parsing rule. |
Sure! |
# [5.5.0](v5.4.0...v5.5.0) (2019-04-23) ### Bug Fixes * **createInstantSearch:** change the User-Agent to use the new specs ([#2209](#2209)) ([642ba0b](642ba0b)) ### Features * **DOMMaps:** expose withGoogleMaps HOC [PART-1] ([#2000](#2000)) ([2ae1dea](2ae1dea)) * **queryRules:** add Query Rules features ([#2286](#2286)) ([3ae9c01](3ae9c01)) * **insights:** add insights features ([#2215](#2215)) ([961e7a7](961e7a7))
Summary
Update the user agent from
react-instantsearch ${version}
toreact (${React.version}); react-instantsearch (${version})
Result
react (16.8.4);react-instantsearch (5.4.0);
PRD here: https://docs.google.com/document/d/18YaTUx6hUuR4_ppVijH3zDyKpUVCASAfZKbKjvWFXjE/edit#heading=h.w2yjrvr134ce