This repository has been archived by the owner on Dec 30, 2022. It is now read-only.
fix(ua): change the User-Agent to use the new specs lib (version) #2209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for react-instantsearch ready! Built with commit ba7650b https://deploy-preview-2209--react-instantsearch.netlify.com |
Haroenv
approved these changes
Mar 21, 2019
samouss
reviewed
Mar 21, 2019
|
yes! can we have react-instantsearch-server directly? |
|
You mean |
|
yes to simplify the parsing rule. |
|
Sure! |
samouss
added a commit
that referenced
this pull request
Apr 23, 2019
# [5.5.0](v5.4.0...v5.5.0) (2019-04-23) ### Bug Fixes * **createInstantSearch:** change the User-Agent to use the new specs ([#2209](#2209)) ([642ba0b](642ba0b)) ### Features * **DOMMaps:** expose withGoogleMaps HOC [PART-1] ([#2000](#2000)) ([2ae1dea](2ae1dea)) * **queryRules:** add Query Rules features ([#2286](#2286)) ([3ae9c01](3ae9c01)) * **insights:** add insights features ([#2215](#2215)) ([961e7a7](961e7a7))
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Update the user agent from
react-instantsearch ${version}toreact (${React.version}); react-instantsearch (${version})Result
react (16.8.4);react-instantsearch (5.4.0);
PRD here: https://docs.google.com/document/d/18YaTUx6hUuR4_ppVijH3zDyKpUVCASAfZKbKjvWFXjE/edit#heading=h.w2yjrvr134ce