Skip to content
This repository has been archived by the owner on Dec 30, 2022. It is now read-only.

refactor(lodash): replace isFinite #2458

Merged
merged 2 commits into from
May 17, 2019
Merged

refactor(lodash): replace isFinite #2458

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7c26b9c
refactor(lodash): replace isFinite
Haroenv May 16, 2019
08c7bcf
chore: remove needless typeof
Haroenv May 16, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
13 changes: 6 additions & 7 deletions packages/react-instantsearch-core/src/connectors/connectRange.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
import { isFinite as _isFinite } from 'lodash';
import PropTypes from 'prop-types';
import createConnector from '../core/createConnector';
import {
Expand Down Expand Up @@ -41,18 +40,18 @@ function getCurrentRange(boundaries, stats, precision) {
const pow = Math.pow(10, precision);

let min;
if (_isFinite(boundaries.min)) {
if (typeof boundaries.min === 'number' && isFinite(boundaries.min)) {
min = boundaries.min;
} else if (_isFinite(stats.min)) {
} else if (typeof stats.min === 'number' && isFinite(stats.min)) {
min = stats.min;
} else {
min = undefined;
}

let max;
if (_isFinite(boundaries.max)) {
if (typeof boundaries.max === 'number' && isFinite(boundaries.max)) {
max = boundaries.max;
} else if (_isFinite(stats.max)) {
} else if (typeof stats.max === 'number' && isFinite(stats.max)) {
max = stats.max;
} else {
max = undefined;
Expand Down Expand Up @@ -151,8 +150,8 @@ function refine(props, searchState, nextRefinement, currentRange, context) {
const nextMinAsNumber = !isMinReset ? parseFloat(nextMin) : undefined;
const nextMaxAsNumber = !isMaxReset ? parseFloat(nextMax) : undefined;

const isNextMinValid = isMinReset || _isFinite(nextMinAsNumber);
const isNextMaxValid = isMaxReset || _isFinite(nextMaxAsNumber);
const isNextMinValid = isMinReset || isFinite(nextMinAsNumber);
samouss marked this conversation as resolved.
Show resolved Hide resolved
const isNextMaxValid = isMaxReset || isFinite(nextMaxAsNumber);

if (!isNextMinValid || !isNextMaxValid) {
throw Error("You can't provide non finite values to the range connector.");
Expand Down